Draft
Conversation
|
Shaka error 1006 happens on the DASH manifest path because itags don't match. They get filtered out for SABR (see unixfox@13f0943) but not here: https://github.com/unixfox/invidious/blob/13f094302392228d3db2a07ece67a6cf3db2b588/assets/js/sabr_player.js#L551-L557 Diff from Kira: diff --git a/src/composables/useYoutubePlayer.ts b/src/composables/useYoutubePlayer.ts
index 9d5803c..7156e83 100644
--- a/src/composables/useYoutubePlayer.ts
+++ b/src/composables/useYoutubePlayer.ts
@@ -689,7 +689,12 @@ export function useYoutubePlayer() {
`${videoInfo.streaming_data.dash_manifest_url}/mpd_version/7`;
} else {
try {
+ // Filter out formats with xtags (DRC variants) to prevent duplicate itag issues
+ // that cause "Could not determine current format" errors in the SABR adapter.
+ // This must match the filter applied to setServerAbrFormats() above.
+ // Note: format_filter is a reject filter - return true to EXCLUDE the format.
const dashManifest = await videoInfo.toDash({
+ format_filter: (format) => !!format.xtags,
manifest_options: {
is_sabr: true,
captions_format: "vtt",Fixes it in my experience Edit: turns out this fix causes audio to disappear from dubbed videos. This is what ended up fixing it: acheong08/invidious-sabr-player@54c6700 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is for adding SABR support to invidious.
Close #5263
TODO